Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Extension Functions After Export #565

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Register Extension Functions After Export #565

merged 1 commit into from
Jan 12, 2024

Conversation

dreblen
Copy link
Contributor

@dreblen dreblen commented Jan 12, 2024

Because the export method closes and reopens the database, it must follow the same initialization steps that occur during the first open. One step that was missing was registering extension functions. This commit does the following:

  • Added call to registerExtensionFunctions() after the database is reloaded during the exportDatabase() call.
  • Added test for this scenario.

- Added call to registerExtensionFunctions() after the database is reloaded during the exportDatabase() call.
- Added test for this scenario.
@lovasoa lovasoa merged commit ea6ae62 into sql-js:master Jan 12, 2024
1 check passed
@lovasoa
Copy link
Member

lovasoa commented Jan 12, 2024

thanks !

@dreblen
Copy link
Contributor Author

dreblen commented Jan 13, 2024

Glad I could contribute! Should I have any expectation of when this would make it into an official release for use downstream?

@lovasoa
Copy link
Member

lovasoa commented Jan 16, 2024

I just released v1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants