Feat/add local build instructions to readme #58
Conversation
Ryanmtate
changed the base branch from
feat/oid4vp-jwt-vc-support
to
skit-459-integrate-oid4vp-into-mobile-sdk-rust-swift-kotlin
Ryanmtate
force-pushed
the
feat/add-local-build-instructions-to-readme
branch
from
a9343d2
to
bc98e43
Compare
kotlin/mobilesdkrs/build.gradle
Outdated
| debug(MavenPublication) { | ||
| groupId = 'com.spruceid.mobile.sdk.rs' | ||
| artifactId = "mobilesdkrs" | ||
| version = System.getenv("VERSION") | ||
|
|
||
| afterEvaluate { | ||
| from components.release | ||
| } | ||
| } |
There was a problem hiding this comment.
NOTE: I am adding this back because it is needed for releasing to mavenLocal() repository.
There was a problem hiding this comment.
Just for reference, for this to be able to stay in the repo, the release action in the CI needs to be updated use individual publish calls, that is, ./gradlew publishReleasePublicationToGitHubPackagesRepository and ./gradlew publishReleasePublicationToNmcpReleaseRepository instead of ./gradlew publish.
There was a problem hiding this comment.
Ah, this is good to know! 🙏
There was a problem hiding this comment.
Does publishReleasePublicationToCentralPortal provide support for Nmcp?
I didn't add publishReleasePublicationToNmcpReleaseRepository step to the release, but I did replace publish with publishReleasePublicationToGitHubPackagesRepository in 77e35df
Ryanmtate
force-pushed
the
feat/add-local-build-instructions-to-readme
branch
from
ebf1d4a
to
aca62b4
Compare
| cd kotlin/ && VERSION=x.y.z ./gradlew publishDebugPublicationToMavenLocal | ||
| ``` | ||
|
|
||
| Where `VERSION` is set to a SemVer (Semantic Versioning). Note that it is possible to use a tagged version, e.g. `0.0.33-SNAPSHOT`, which may be preferrable to denote |
There was a problem hiding this comment.
I might make this language even stronger. Something like "It is strongly advised to use a tagged version, as using a regular version can cause confusion down the line when the local maven repository contains conflicting version numbers." (Yes, this has bit me in the past).
Ryanmtate
force-pushed
the
skit-459-integrate-oid4vp-into-mobile-sdk-rust-swift-kotlin
branch
from
f17fe1f
to
dfb7b39
Compare
Ryanmtate
force-pushed
the
feat/add-local-build-instructions-to-readme
branch
from
77e35df
to
0005376
Compare
No description provided.