-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add local build instructions to readme #58
Conversation
a9343d2
to
bc98e43
Compare
kotlin/mobilesdkrs/build.gradle
Outdated
debug(MavenPublication) { | ||
groupId = 'com.spruceid.mobile.sdk.rs' | ||
artifactId = "mobilesdkrs" | ||
version = System.getenv("VERSION") | ||
|
||
afterEvaluate { | ||
from components.release | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: I am adding this back because it is needed for releasing to mavenLocal()
repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for reference, for this to be able to stay in the repo, the release action in the CI needs to be updated use individual publish
calls, that is, ./gradlew publishReleasePublicationToGitHubPackagesRepository
and ./gradlew publishReleasePublicationToNmcpReleaseRepository
instead of ./gradlew publish
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is good to know! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does publishReleasePublicationToCentralPortal
provide support for Nmcp?
I didn't add publishReleasePublicationToNmcpReleaseRepository
step to the release, but I did replace publish
with publishReleasePublicationToGitHubPackagesRepository
in 77e35df
ebf1d4a
to
aca62b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment but generally LGTM.
cd kotlin/ && VERSION=x.y.z ./gradlew publishDebugPublicationToMavenLocal | ||
``` | ||
|
||
Where `VERSION` is set to a SemVer (Semantic Versioning). Note that it is possible to use a tagged version, e.g. `0.0.33-SNAPSHOT`, which may be preferrable to denote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might make this language even stronger. Something like "It is strongly advised to use a tagged version, as using a regular version can cause confusion down the line when the local maven repository contains conflicting version numbers." (Yes, this has bit me in the past).
f17fe1f
to
dfb7b39
Compare
77e35df
to
0005376
Compare
No description provided.