Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interoperability updates for OID4VCI #56

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Conversation

theosirian
Copy link
Contributor

  • Update relevant dependencies
  • Add debug publication to android project
  • Add DID and VM generation for did:key and did:jwk
  • Move proof of possession code to its own module
  • Update OID4VCI functions to match interoperability changes in oid4vci-rs

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Copy link
Member

@Juliano1612 Juliano1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with VCPlayground and here is the list of credentials that are working and not working:

Working

  • Employment authorization document
  • Open Badge
  • Permanent Resident
  • JFF x vc-edu PF2
  • Intro to CHAPI
  • Alumni
  • Medical Technician
  • Driver's License
  • Certificate of Naturalization
  • Movie Ticket
  • JFF x vc-edu PF3
  • Safe Chef
  • Academic Course
  • GS1 8110 Coupon
  • Loyalty Card

Not working:

  • Alumni
  • Medical Technician
  • Driver's License
  • Certificate of Naturalization
  • Movie Ticket
  • JFF x vc-edu PF3
  • Safe Chef
  • Academic Course
  • GS1 8110 Coupon
  • Loyalty Card

It's possible to test the issuance by using this mobile-sdk-ios-app version

Everything is working well now! LGTM

…d tokio runtime wrapper for did resolution in credential verification; Add trace logs in exchange_credential

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Copy link
Member

@Juliano1612 Juliano1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's working with the demo apps.

I'm not fluent in Rust, so I'll leave this part to @cobward and @sbihel

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
@theosirian theosirian merged commit 0ce06fd into main Oct 7, 2024
3 checks passed
@theosirian theosirian deleted the update-with-interop branch October 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants