Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute ReturnType#isDto eagerly #3160

Closed
wants to merge 1 commit into from
Closed

Compute ReturnType#isDto eagerly #3160

wants to merge 1 commit into from

Conversation

mipo256
Copy link
Contributor

@mipo256 mipo256 commented Sep 21, 2024

In order to avoid recalculation of isDto for ReturnedType it makes sense to wrap the computed result with Lazy, giving the fact that type is actually final.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 21, 2024
@mp911de mp911de self-assigned this Sep 23, 2024
@mp911de mp911de changed the title Added Lazy wrapper for ReturnType#isDto Compute ReturnType#isDto eagerly Sep 26, 2024
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 26, 2024
@mp911de
Copy link
Member

mp911de commented Sep 26, 2024

isDto is computed only once and doesn't change so we can safely pre-compute the value without the need for Lazy. I'm going to apply that change during the merge.

@mp911de mp911de added this to the 3.2.11 (2023.1.11) milestone Sep 26, 2024
mp911de pushed a commit that referenced this pull request Sep 26, 2024
@mipo256 @mp911de
Added Lazy wrapper for ReturnType#isDto.
15afbff 
Closes #3160
mp911de added a commit that referenced this pull request Sep 26, 2024
@mp911de
Polishing.
f065f40 
See #3160
mp911de pushed a commit that referenced this pull request Sep 26, 2024
@mipo256 @mp911de
Added Lazy wrapper for ReturnType#isDto.
96621b3 
Closes #3160
mp911de added a commit that referenced this pull request Sep 26, 2024
@mp911de
Polishing.
b84d603 
See #3160
@mp911de mp911de closed this in 4a620ed Sep 26, 2024
mp911de added a commit that referenced this pull request Sep 26, 2024
@mp911de
Polishing.
737502c 
See #3160
@mp911de
Copy link
Member

mp911de commented Sep 26, 2024

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: task A general task
Projects
None yet
Milestone
3.2.11 (2023.1.11)
Development

Successfully merging this pull request may close these issues.
3 participants
@mipo256 @mp911de @spring-projects-issues