Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sap-Syrup balance #32996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sap-Syrup balance #32996

wants to merge 1 commit into from

Conversation

Aisu9
Copy link

@Aisu9 Aisu9 commented Oct 25, 2024

About the PR

Change the conversion rate from 12:1 to 2:1

Why / Balance

12 to 1 syrup is quite abysmal for a conversion rate for a flavor-only liquid, also you don't want to kill-murder a Diona for your pancake.

Changelog
Boiling Sap now produce more Syrup

Change the conversion rate from 12:1 to 2:1
@github-actions github-actions bot added the No C# For things that don't need code. label Oct 25, 2024
@Aisu9
Copy link
Author

Aisu9 commented Oct 25, 2024

there we go, forgot how to do it for a second!

@Aisu9 Aisu9 changed the title Sap-Pancake balance Sap-Syrup balance Oct 25, 2024
@Blackern5000
Copy link
Contributor

As the person who originally added this, you'll need to make sure the amount of water vapor produced is still consistent with how much is boiled away (just stick a distiller in a closed room, make syrup in that room, and see how much water it produces), and also change the reagents you get from centrifuging sap to line up as well.

@Aisu9
Copy link
Author

Aisu9 commented Oct 25, 2024

As the person who originally added this, you'll need to make sure the amount of water vapor produced is still consistent with how much is boiled away (just stick a distiller in a closed room, make syrup in that room, and see how much water it produces), and also change the reagents you get from centrifuging sap to line up as well.

i would be happy to do it, but i am nowhere near familiar with the files and it was already a nightmare to find these 2 silly lines to change

@Doru991
Copy link
Contributor

Doru991 commented Oct 25, 2024

Your changelog section isn't formatted correctly and should be more direct, please check the PR guidelines again. It should be something like:
Changelog
🆑

  • tweak: Making syrup requires less sap now.

@Doru991
Copy link
Contributor

Doru991 commented Oct 25, 2024

As the person who originally added this, you'll need to make sure the amount of water vapor produced is still consistent with how much is boiled away (just stick a distiller in a closed room, make syrup in that room, and see how much water it produces), and also change the reagents you get from centrifuging sap to line up as well.

Realistically this would mean making the ratio of water and sugar about 6:4, and making less water vapor come out, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants