Issues #19: Player Count Filters #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the count filters thing, I think maybe the best solution would be a separate check box that enables the number field? |
Sure, I pushed some changes.
|
|
Sorry for taking so long to get to this. I'll just quickly clean it up and merge it. |
PJB3005
added a commit
that referenced
this pull request
Aug 9, 2023
Based on #91 I ended up doing this somewhat differently. The ServerFilter model (and the DB table) were intended to be a set, so storing the actual count values in them didn't make much sense. Instead I decided to store the actual count values as a regular CVar. This also meant the code for the basic filters handling didn't need massive revamps.
|
Done in that commit. |
Skyedra
pushed a commit
to Skyedra/SS14.Launcher
that referenced
this pull request
Aug 28, 2023
… Hide Empty / Hide Full Based on space-wizards#91 I ended up doing this somewhat differently. The ServerFilter model (and the DB table) were intended to be a set, so storing the actual count values in them didn't make much sense. Instead I decided to store the actual count values as a regular CVar. This also meant the code for the basic filters handling didn't need massive revamps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Issue #19, this PR adds 3 new filters: Filtering Full Servers, Filtering Max Players, Filtering Min Players.
There is, however, a small issue with the NumericUpDown AvaloniaUI element: it does not allow null-able values (yet? see: AvaloniaUI/Avalonia#8113). Because of this, once the player count max value is set, there is no way to reset it, For now, I see 3 solutions:
Open to Input!