Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable compat mode on MacOS forcibly #180

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Disable compat mode on MacOS forcibly #180

merged 4 commits into from
Sep 9, 2024

Conversation

VasilisThePikachu
Copy link
Member

No description provided.

PJB3005
PJB3005 requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic for disabling should get ran inside the actual connection code instead (ConnectLaunchClient), creation of the ViewModel mutating state is not a great way to architect it.

SS14.Launcher/Assets/Locale/en-US/text.ftl Outdated Show resolved Hide resolved
PJB3005
PJB3005 requested changes Sep 9, 2024
View reviewed changes
SS14.Launcher/Models/Connector.cs Outdated Show resolved Hide resolved
@PJB3005 PJB3005 merged commit 83fc005 into space-wizards:master Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 PJB3005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VasilisThePikachu @PJB3005