Separate window creation in OSWindow.Show() to allow creation in the background
#5489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSWindow now created ClydeWindow and WindowRoot immediately, but non-visible in the background Also added the ability to programatically resize an open window
Iamgoofball
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
░░░░░░░░░░░░▄▄
░░░░░░░░░░░█░░█
░░░░░░░░░░░█░░█
░░░░░░░░░░█░░░█
░░░░░░░░░█░░░░█
███████▄▄█░░░░░██████▄
▓▓▓▓▓▓█░░░░░░░░░░░░░░█
▓▓▓▓▓▓█░░░░ PJB, ░░░░░░░█
▓▓▓▓▓▓█░░░░Add This░░░░█
▓▓▓▓▓▓█░░░░Please!░░░░░█
▓▓▓▓▓▓█░░░░░░░░░░░░░░█
▓▓▓▓▓▓█████░░░░░░░░░█
██████▀░░░░▀▀██████▀
PJB3005
reviewed
Oct 16, 2024
Yea, splitting |
wixoaGit
changed the title
OSWindow.Show() to allow creation in the background
|
The tests are passing on my machine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSWindow wouldn't create the window and its UI root until
Show()was called. This caused issues for controls we needed to initialize & run before ever being visible. Now they are both created immediately, withShow()being used to make them visible.This also required being able to set a window's size after creation, so I added the ability to do that. This is something OpenDream was going to need at some point anyway.