-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate window creation in OSWindow.Show()
to allow creation in the background
#5489
Conversation
OSWindow now created ClydeWindow and WindowRoot immediately, but non-visible in the background Also added the ability to programatically resize an open window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
░░░░░░░░░░░░▄▄
░░░░░░░░░░░█░░█
░░░░░░░░░░░█░░█
░░░░░░░░░░█░░░█
░░░░░░░░░█░░░░█
███████▄▄█░░░░░██████▄
▓▓▓▓▓▓█░░░░░░░░░░░░░░█
▓▓▓▓▓▓█░░░░ PJB, ░░░░░░░█
▓▓▓▓▓▓█░░░░Add This░░░░█
▓▓▓▓▓▓█░░░░Please!░░░░░█
▓▓▓▓▓▓█░░░░░░░░░░░░░░█
▓▓▓▓▓▓█████░░░░░░░░░█
██████▀░░░░▀▀██████▀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not a fan of the breaking changes introduced here. Would it be possible to add a new function instead that creates the window without showing?
Yea, splitting |
OSWindow.Show()
to allow creation in the background
The tests are passing on my machine |
OSWindow wouldn't create the window and its UI root until
Show()
was called. This caused issues for controls we needed to initialize & run before ever being visible. Now they are both created immediately, withShow()
being used to make them visible.This also required being able to set a window's size after creation, so I added the ability to do that. This is something OpenDream was going to need at some point anyway.