Fix bugs on windows,'async:1: no such file or directory: ../external/async/async.zsh' #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or caused by creating soft links in Windows.
jeffwidman
reviewed
Sep 27, 2024
|
Also, I don't use Windows, so it'd be great if someone who does could test this to get a second pair of 👀 before merging... |
Sorry for saying from the nowhere, but IMHO, that trailing space highlight in git diff, especially for .md file, looks more like a GitHub Bug for me in 2k24. |
Maybe now is ok? I'm not sure. I use python script to remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the README.md file and provided a bat command to fix the error caused by creating soft links in Windows.
Fixes #2016
Proposed Changes