enhance: refurbished bzip2 build script #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tai271828
approved these changes
Nov 7, 2021
|
Thanks for the quick fix! |
yungyuc
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of #92 is bzip2 using
-sonameasLDFLAGSin makefile, but MacOS default C compiler is clang and theLDFLAGSis-install_name, so devenv failed to build bzip2 at MacOS.It seems bzip2 currently migrated from sourceware to gitlab, and it using
CMakeinstead of pureMakefile, so I refurbishedbzip2build script.Here is the result of GitHub workflow : Result