Merge pull request #123 from solidjs-community/fix/multiple-sync-props

Only mark props as reactive for non-sync callbacks, fixes #110.
solidjs-community · Dec 30, 2023 · 4282b29 · 4282b29
2 parents 16a5209 + 31fbc88
commit 4282b29
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/docs/reactivity.md b/docs/reactivity.md
@@ -816,6 +816,12 @@ function Component(props) {
  return <div use:someHook={() => props.count} />;
 }
 
+function formObjectDispatch(formObject, action) {
+ const { field } = action.payload;
+ formObject.findIndex((props) => props.field === field);
+ formObject.findIndex((props) => props.field === field);
+}
+
 ```
 <!-- AUTO-GENERATED-CONTENT:END -->
 

diff --git a/src/rules/reactivity.ts b/src/rules/reactivity.ts
@@ -315,11 +315,11 @@ export default createRule<Options, MessageIds>({
  /** Populates the function stack. */
  const onFunctionEnter = (node: ProgramOrFunctionNode) => {
  if (isFunctionNode(node)) {
- markPropsOnCondition(node, (props) => isPropsByName(props.name));
  if (scopeStack.syncCallbacks.has(node)) {
  // Ignore sync callbacks like Array#forEach and certain Solid primitives
  return;
  }
+ markPropsOnCondition(node, (props) => isPropsByName(props.name));
  }
  scopeStack.push(new ScopeStackItem(node));
  };

diff --git a/test/rules/reactivity.test.ts b/test/rules/reactivity.test.ts
@@ -328,6 +328,12 @@ export const cases = run("reactivity", rule, {
  function Component(props) {
  return <div use:someHook={() => props.count} />;
  }`,
+ // f*cking insane edge case with multiple functions taking props as sync callbacks (#110)
+ `function formObjectDispatch(formObject, action) {
+ const { field } = action.payload;
+ formObject.findIndex((props) => props.field === field);
+ formObject.findIndex((props) => props.field === field);
+ }`,
  ],
  invalid: [
  // Untracked signals