Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/nirs interface #3094

Merged
merged 56 commits into from
Oct 8, 2020
Merged

Topic/nirs interface #3094

merged 56 commits into from
Oct 8, 2020

Conversation

nickmorales
Copy link
Contributor

@nickmorales nickmorales commented Oct 5, 2020

Description

Upload NIRS data with spectra aggregation using Waves R package.
Display plot of NIRS for queried data.
Includes test and tests pass.

Required an update to the R waves package: solgenomics/R_libs#5

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

nickmorales and others added 30 commits September 20, 2020 14:50
Copy link
Member

@lukasmueller lukasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@lukasmueller lukasmueller merged commit d8da74c into master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants