Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memalign and posix_memalign methods for buffered finalization #18

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

jacob-hughes
Copy link

The Rust compiler uses these methods instead of generic malloc under certain conditions and without support we can get rustc assertion errors in standard library methods which expect certain alignment requirements.

This uses the same allocation semantics from existing GC_memalign and GC_posix_memalign definitions inside mallocx.c

@ltratt ltratt added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
@jacob-hughes
Copy link
Author

Fixed here: 27bf9af

@ltratt
Copy link
Member

ltratt commented Apr 17, 2024

Please squash.

The Rust compiler uses these methods instead of generic malloc under
certain conditions and without support we can get rustc assertion errors
in standard library methods which expect certain alignment requirements.

This uses the same allocation semantics from existing `GC_memalign` and
`GC_posix_memalign` definitions inside mallocx.c
@jacob-hughes
Copy link
Author

Squashed

@ltratt ltratt added this pull request to the merge queue Apr 17, 2024
Merged via the queue into softdevteam:master with commit 7d909b4 Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants