Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add participantChannel to isolate keeping count of participants #408

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on May 18, 2021

  1. Add participantChannel to isolate keeping count of participants

    participantChannel is a special channel used only to keep track of participants. No data goes through it. This prevents bugs associated with having non-participating subscribers on the channels that have data going through them.
    doodlesbykumbi authored May 18, 2021
    Configuration menu
    Copy the full SHA
    8a94e51 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Add tests for spying subscribers

    The participant channel is used to count subscribers. Any counted but non-participating subscribers result in a timeout error when gathering responses. Non-participating clients can subscriber to the request and response channels without issue.
    doodlesbykumbi authored May 19, 2021
    Configuration menu
    Copy the full SHA
    7ce934d View commit details
    Browse the repository at this point in the history