Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1491199 Introduce ast.proto to the Snowpark client #2549

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

sfc-gh-oplaton
Copy link
Contributor

@sfc-gh-oplaton sfc-gh-oplaton commented Oct 31, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1491199

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

Introduce ast.proto under src/snowflake/snowpark/_internal/proto and ast_pb2.py under the generated subdirectory.
ast.proto gets created from the contents of Snowpark/ast, using ir-dsl-c. The chain is AST IR -> ir-dsl-c -> ast.proto -> Python protoc -> ast_pb2.py.
We are merging both ast.proto and ast_pb2.py because the Snowpark repository is not fully equipped to generate the Python client stubs at packaging time. This change is a work in progress and blocked behind IT tickets for an indeterminate amount of time.
A complete description of the AST model is too large to include here. We are currently working on an AST IR developer guide, as well.

Co-Authored-By: Arthur Zwiegincew <arthur.zwiegincew@snowflake.com>
Co-Authored-By: Eric Vandenberg <eric.vandenberg@snowflake.com>
Co-Authored-By: Hemit Shah <hemit.shah@snowflake.com>
Co-Authored-By: Leonhard Spiegelberg <leonhard.spiegelberg@snowflake.com>
Co-Authored-By: Ovidiu Platon <ovidiu.platon@snowflake.com>
Co-Authored-By: Varnika Budati <varnika.budati@snowflake.com>
@sfc-gh-oplaton sfc-gh-oplaton requested review from a team as code owners October 31, 2024 21:41
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Oct 31, 2024
Copy link
Contributor

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg merged commit 191c7b5 into main Oct 31, 2024
43 of 45 checks passed
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg deleted the oplaton/snow-1491199-3sp-phase0-proto branch October 31, 2024 23:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants