NO-SNOW: Run tests with multithreading mode enabled by default #2539
+72
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-aalam
added
the
NO-CHANGELOG-UPDATES
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-aalam
requested review from
sfc-gh-evandenberg,
sfc-gh-helmeleegy,
sfc-gh-smirzaei,
sfc-gh-yuwang and
sfc-gh-jrose
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-jdu
reviewed
Oct 31, 2024
.github/workflows/precommit.yml
Outdated
| @@ -471,8 +471,8 @@ jobs: | |||
| .tox/.coverage | |||
| .tox/coverage.xml | |||
|
|
|||
| test-snowpark-multithreading-mode: | |||
| name: Test Snowpark Multithreading py-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.cloud-provider }} | |||
| test-snowpark-disable-multithreading-mode: | |||
There was a problem hiding this comment.
should we move disable mode test to daily test?
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR makes the following two changes:
i. Run with multithreaded mode enabled by default. Move
--multithreading_modeto--disable_multithreading_modeand run snowpark tests in multithreaded mode.ii. Remove pytest marker
multithreaded_runwhich was used to run a subset of snowpark pandas test with multithreaded-mode enabled. This is no longer needed as the snowpark-pandas tests will run with multithreaded mode enabled.