Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1764136: Infer quoted identifiers for Join #2535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SNOW-1764136: Infer quoted identifiers for Join #2535

wants to merge 1 commit into from

Conversation

sfc-gh-jdu
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1764136

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-jdu sfc-gh-jdu added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Oct 29, 2024
@sfc-gh-jdu sfc-gh-jdu marked this pull request as ready for review October 30, 2024 18:00
@sfc-gh-jdu sfc-gh-jdu requested review from a team as code owners October 30, 2024 18:00
sfc-gh-helmeleegy
sfc-gh-helmeleegy reviewed Oct 30, 2024
View reviewed changes
src/snowflake/snowpark/_internal/analyzer/metadata_utils.py
@@ -103,6 +112,26 @@ def infer_metadata(
analyzer,
df_aliased_col_name_to_real_col_name,
)
# When source_plan is a Join, we only infer its quoted identifiers
# if two plans don't have any common quoted identifier
# This is conservative and avoids parsing join condition, but works for Snowpark pandas,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a big help in cutting down on the unnecessary describe queries for pandas workloads. Great!

sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Jianzhun!

@sfc-gh-jdu sfc-gh-jdu force-pushed the jdu-SNOW-1764136-join branch 2 times, most recently from 3681811 to eba3ea3 Compare October 31, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jdu @sfc-gh-aalam @sfc-gh-helmeleegy