SNOW-1707707: Add support for Index.to_numpy #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-helmeleegy
requested review from
sfc-gh-evandenberg and
sfc-gh-nkrishna
| @@ -2601,6 +2698,10 @@ def __array__(self, dtype: Any = None) -> np.ndarray: | |||
| """ | |||
| The array interface, return the values. | |||
| """ | |||
| # Ensure that the existing index dtype is preserved in the returned array | |||
| # if no other dtype is given. | |||
| if dtype is None: | |||
There was a problem hiding this comment.
This fixes a pre-existing issue that was causing some test failures with the introduction of Index.to_numpy.
sfc-gh-helmeleegy
force-pushed
the
helmeleegy-SNOW-1707707
branch
2 times, most recently
from
d8d190c
to
bb04347
Compare
sfc-gh-helmeleegy
force-pushed
the
helmeleegy-SNOW-1707707
branch
from
bb04347
to
e60801a
Compare
| query_count=3 if isinstance(key, native_pd.Index) else 1, join_count=1 | ||
| ): | ||
| # df[boolean list-like key] is the same as df.loc[:, boolean list-like key] | ||
| if isinstance(key, native_pd.Index): |
There was a problem hiding this comment.
There was no need to convert the native pandas index into a Snowpark pandas index when the df it's being passed to is actually a native pandas DataFrame. This was also causing test failures on the introduction of Index.to_numpy.
sfc-gh-nkrishna
approved these changes
Oct 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1707707
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add support for Index.to_numpy.