Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1331955: Remove pandas CHANGELOG #1644

Merged
merged 1 commit into from
May 21, 2024
Merged

SNOW-1331955: Remove pandas CHANGELOG #1644

merged 1 commit into from
May 21, 2024

Conversation

sfc-gh-nkrishna
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna commented May 21, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1331955

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    This PR removes pandas CHANGELOG and cleans up pandas changelog and changedoc CI tests

@sfc-gh-nkrishna
SNOW-1331955: Remove pandas CHANGELOG
617495a 
Signed-off-by: Naren Krishna <naren.krishna@snowflake.com>
@sfc-gh-nkrishna sfc-gh-nkrishna requested review from a team as code owners May 21, 2024 16:47
@sfc-gh-nkrishna sfc-gh-nkrishna added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels May 21, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna requested a review from a team May 21, 2024 16:56
sfc-gh-vbudati
sfc-gh-vbudati approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-vbudati sfc-gh-vbudati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long, PANDAS_CHANGELOG.md. 🫡 😔 💐

@sfc-gh-nkrishna sfc-gh-nkrishna merged commit 0117c7c into main May 21, 2024
36 of 39 checks passed
@sfc-gh-nkrishna sfc-gh-nkrishna deleted the nkrishna-SNOW-1331955-remove-pandas-changelog branch May 21, 2024 23:45
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-yzou sfc-gh-yzou sfc-gh-yzou approved these changes

@sfc-gh-vbudati sfc-gh-vbudati sfc-gh-vbudati approved these changes

@sfc-gh-dpetersohn sfc-gh-dpetersohn Awaiting requested review from sfc-gh-dpetersohn sfc-gh-dpetersohn is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-nkrishna @sfc-gh-azhan @sfc-gh-yzou @sfc-gh-vbudati