Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Snowflake Team, we wanted to use the Snowpark Java API in a project but the Scala version got in our way. We have forked and bumped Scala to 2.13, and done minimal work to make it build. This lets us get on with our project.
We are not set up to run tests, and we think some of our changes may not be optimal. For example producing some additional copies of stuff (.toSeq). But FWIW here are our changes.
If nothing else you can count this as a +1 on the request to release these bindings for Scala 2.13 👍. Cheers!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-899949: Upgrade Scala to
v2.13
? #48Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
We updated Scala and Scalatest dependencies and then made everything compile.
Pre-review checklist
(For Snowflake employees)