Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-989128 Create Parent POM #73

Merged
merged 1 commit into from
Dec 11, 2023
Merged

SNOW-989128 Create Parent POM #73

merged 1 commit into from
Dec 11, 2023

Conversation

sfc-gh-bli
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Replace this with a short description of how your code change solves the related issue.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

sfc-gh-zli
sfc-gh-zli reviewed Dec 11, 2023
View reviewed changes
fips-pom.xml
<artifactId>snowpark-parent</artifactId>
<version>1.10.0-SNAPSHOT</version>
<relativePath>./parent-pom.xml</relativePath>
</parent>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check on whether our POM test checks for parents or not.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passed the merging gate

@sfc-gh-bli sfc-gh-bli merged commit 5456174 into main Dec 11, 2023
13 checks passed
@sfc-gh-bli sfc-gh-bli deleted the snow-989128-2 branch December 11, 2023 21:05
sfc-gh-bli added a commit that referenced this pull request Dec 13, 2023
@sfc-gh-bli
Revert "SNOW-989128 Create Parent POM (#73)"
27722eb 
This reverts commit 5456174.
sfc-gh-bli added a commit that referenced this pull request Dec 13, 2023
@sfc-gh-bli
SNOW-989128 Rollback Parent Pom (#75)
a920b69 
* Revert "SNOW-989128 Create Parent POM (#73)"

This reverts commit 5456174.

* update fips-pom

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-zli sfc-gh-zli sfc-gh-zli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-bli @sfc-gh-zli