SNOW-1022196 Support binding parameters for snowpark java api #171
+134
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bli
reviewed
Nov 1, 2024
| * @param query The SQL statement to execute. | ||
| * @param params The binding parameters for SQL statement (optional) | ||
| * @return A {@code DataFrame} object | ||
| * @since 0.8.0 |
There was a problem hiding this comment.
Suggested change
| * @since 0.8.0 | |
| * @since 1.15.0 |
| @@ -857,20 +871,24 @@ private[snowpark] class ServerConnection( | |||
|
|
|||
| logDebug(s"""execute plan in async mode: | |||
| |----------SNOW----------- | |||
| | | |||
| val multipleStatements = queries.mkString("; ") | ||
| // Note binding parameters only supported for single query | ||
| val bindingParameters = | ||
| if (plan.queries.length == 1) plan.queries.last.params else Seq() |
There was a problem hiding this comment.
If it doesn't support multiple statements, let's throw a user exception here.
you can find example from there https://github.com/snowflakedb/snowpark-java-scala/blob/main/src/main/scala/com/snowflake/snowpark/internal/ErrorMessage.scala
I checked the code, the only one usage is caching dataframe. So user can't cache dataframe if invoke binding.
I think we can improve it later. Now we cache dataframe by Create Table + Insert Into table, these two queries can be combined into one. Anyway, let's don't do it now, just throw one exception.
| val df5 = | ||
| session.sql("select * from values (?,?),(?,?),(?,?) as T(a, b)", List(1, 2, 2, 1, 4, 3)) | ||
| val df6 = df4.union(df5).filter(col("a") < 3) | ||
| assert(df6.collect() sameElements Array[Row](Row(1, 1), Row(2, 1), Row(1, 2))) |
There was a problem hiding this comment.
it should have two (2, 1) right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-1022196 Support binding parameters for snowpark java api