Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize the application #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dockerize the application #42

wants to merge 1 commit into from

Conversation

huanga
Copy link

@huanga huanga commented Mar 21, 2023

Overview

SNOW-XXXXX

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR adressing? Make sure that there is an accompanying issue to your PR.

    Fixes Dockerize the application #41

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • [?] I am adding a new dependency
    • I am adding new API testing

Unsure if Docker would be considered as a new dependency here.

  1. Please describe how your code solves the related issue.

    Dockerfile - added to enable building of the container image.
    .env.dist - added as example to show how an .env file should be structured.
    m2_settings.xml.dist - added as example to show how an ~/.m2/settings.xml file should be structured.
    Readme.md - updated to reflect how another user may be able to build the container and test for themselves

Pre-review checklist

  • [?] This change has passed precommit
  • [?] I have code coverage for my PR

Not sure about these two -- commit seem to have gone through no problem, and there's no new "code" introduced, just a simple wrapper.

@username-is-already-taken2

Might be worth bumping the number set in your env example for PAGE_LISTING_TOTAL_SIZE as the test will fail with it set to 1000

        if (EnvConstants.PAGE_LISTING_TOTAL_SIZE <= 1000) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize the application
2 participants