Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-XXXXX
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR adressing? Make sure that there is an accompanying issue to your PR.
Fixes Dockerize the application #41
Fill out the following pre-review checklist:
Unsure if Docker would be considered as a new dependency here.
Please describe how your code solves the related issue.
Dockerfile
- added to enable building of the container image..env.dist
- added as example to show how an.env
file should be structured.m2_settings.xml.dist
- added as example to show how an~/.m2/settings.xml
file should be structured.Readme.md
- updated to reflect how another user may be able to build the container and test for themselvesPre-review checklist
Not sure about these two -- commit seem to have gone through no problem, and there's no new "code" introduced, just a simple wrapper.