Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1518540 release public preview #9

Merged
merged 2 commits into from
Aug 13, 2024
Merged

SNOW-1518540 release public preview #9

merged 2 commits into from
Aug 13, 2024

Conversation

sfc-gh-zli
Copy link
Collaborator

Overview

SNOW-1518540 release public preview

Pre-review checklist

  • I attest that this change meets the bar for low risk without security requirements as defined in the Accelerated Risk Assessment Criteria and I have taken the Risk Assessment Training in Workday.
    • Checking this checkbox is mandatory if using the Accelerated Risk Assessment to risk assess the changes in this Pull Request.
    • If this change does not meet the bar for low risk without security requirements (as confirmed by the peer reviewers of this pull request) then a formal Risk Assessment must be completed. Please note that a formal Risk Assessment will require you to spend extra time performing a security review for this change. Please account for this extra time earlier rather than later to avoid unnecessary delays in the release process.
  • This change has passed precommit
  • This change is TEST-ONLY
  • This change has been through a design review process and the test plan is signed off by the owner
  • This change is parameter protected
  • This change has code coverage for the new code added

Copy link

@sfc-gh-vpai sfc-gh-vpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the top-level README.md probably needs to change as well since it refers to the private-preview directory

'200':
description: Successful request.
headers:
X-Snowflake-Request-ID:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we keeping X- header here?

Copy link
Collaborator Author

@sfc-gh-zli sfc-gh-zli Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this field is not internal. It's meant to be public facing.

Copy link
Contributor

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sfc-gh-wshangguan sfc-gh-wshangguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some specs, e.g. dynamic table, is it the manual created version or the one generated by DSL?

@sfc-gh-zli
Copy link
Collaborator Author

For some specs, e.g. dynamic table, is it the manual created version or the one generated by DSL?

It's the one in 8.30 release branch. I think it is generated, because it has x-enum-varname.

@sfc-gh-zli sfc-gh-zli merged commit 055d859 into main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants