Revert "NO-SNOW Enable single buffering in Snowpipe Streaming by default (#924)" #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-rsawicki
approved these changes
Oct 30, 2024
| @@ -495,7 +495,6 @@ public void testStreamingEmptyFlushTime() { | |||
| IngestionMethodConfig.SNOWPIPE_STREAMING.toString()); | |||
| config.put(Utils.SF_ROLE, "ACCOUNTADMIN"); | |||
| config.remove(SnowflakeSinkConnectorConfig.BUFFER_FLUSH_TIME_SEC); | |||
| config.put(SNOWPIPE_STREAMING_ENABLE_SINGLE_BUFFER, "false"); | |||
There was a problem hiding this comment.
we could keep that, it will be later easier to set the default back to true
sfc-gh-wtrefon
approved these changes
Oct 30, 2024
sfc-gh-akowalczyk
approved these changes
Oct 30, 2024
| @@ -133,7 +133,7 @@ public class SnowflakeSinkConnectorConfig { | |||
| public static final String SNOWPIPE_STREAMING_ENABLE_SINGLE_BUFFER = | |||
| "snowflake.streaming.enable.single.buffer"; | |||
|
|
|||
| public static final boolean SNOWPIPE_STREAMING_ENABLE_SINGLE_BUFFER_DEFAULT = true; | |||
| public static final boolean SNOWPIPE_STREAMING_ENABLE_SINGLE_BUFFER_DEFAULT = false; | |||
There was a problem hiding this comment.
So we decided not to introduce / change default values of the SDK flush timeout / flush size?
There was a problem hiding this comment.
Not in 2.5.0. We'll try to figure this out for the next release.
sfc-gh-rsawicki
deleted the
mbobowski-NO-SNOW-disable-single-buffer-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f0e5f23.
Overview
We decided to not enable this setting by default in 2.5.0 release because we are not sure what is the impact on the first read performance.
Pre-review checklist
snowflake.ingestion.method.Yes- Added end to end and Unit Tests.No- Suggest why it is not param protected