SNOW-1772187 nultiple columns evolution bug #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bzabek
force-pushed
the
bzabek-SNOW-1772187-multiple-fields-evolution-bug
branch
from
781f7f4
to
740d52b
Compare
sfc-gh-bzabek
commented
Oct 29, 2024
| waitForOffset(1); | ||
|
|
||
| // and another record with same schema | ||
| service.insert(Collections.singletonList(createKafkaRecord(message, 1, withSchema))); |
There was a problem hiding this comment.
This insertion works fine. It adds 9 new columns.
sfc-gh-bzabek
commented
Oct 29, 2024
| rows = describeTable(tableName); | ||
| assertThat(rows).hasSize(15); | ||
| service.insert(Collections.singletonList(createKafkaRecord(mapRecordJson, 2, false))); | ||
| waitForOffset(3); // FAIL |
There was a problem hiding this comment.
However here it fails to ingest data. With error described in Jira
sfc-gh-bzabek
commented
Oct 29, 2024
| // reinsert record with extra field | ||
| service.insert(Collections.singletonList(createKafkaRecord(mapRecordJson, 2, false))); | ||
| rows = describeTable(tableName); | ||
| assertThat(rows).hasSize(15); |
There was a problem hiding this comment.
Number of columns is correct. Schema evolution logic altered the table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1772187
Open the Jira ticket to see a detailed description.
Below test shows the bug.
Pre-review checklist
snowflake.ingestion.method.Yes- Added end to end and Unit Tests.No- Suggest why it is not param protected