Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-799391: Ignore badssl timeouts in tests #1931

Merged
merged 2 commits into from
Oct 23, 2024
Merged

SNOW-799391: Ignore badssl timeouts in tests #1931

merged 2 commits into from
Oct 23, 2024

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Overview

SNOW-799391

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner October 22, 2024 07:33
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-799391-limit-badssl-calls branch 3 times, most recently from 4963ae9 to be05e94 Compare October 22, 2024 17:02
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title SNOW-799391: Limit badssl calls in tests SNOW-799391: Ignore badssl timeouts in tests Oct 23, 2024
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit e609432 into master Oct 23, 2024
142 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-799391-limit-badssl-calls branch October 23, 2024 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dprzybysz @sfc-gh-pbulawa @sfc-gh-pfus