Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apache Arrow for OpenJDK 17 compatibility #1007

Closed
wants to merge 1 commit into from

Conversation

arouel
Copy link
Contributor

@arouel arouel commented May 23, 2022

Overview

SNOW-XXXXX

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-755767: snowflake-jdbc driver fails with JDK >= 16 #589 and potentially SNOW-379300: Exception when switching from jdk 15 to jdk 16 #533

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Apache Arrow 8.0.0 fixes a problem running on OpenJDK >= 16 (see ARROW-12747).

    I was able to build the snowflake-jdbc project with a shaded Apache Arrow 8.0.0, and it became usable under OpenJDK 17.
    It still requires the JVM argument --add-opens java.base/java.nio=ALL-UNNAMED.

Pre-review checklist

  • This change has passed pre-commit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-wfateem
Copy link
Collaborator

Thank you for the contribution @arouel!
I just wanted to check, did you try building the JDBC driver using this PR branch, run the unit tests and/or test it with your application was experiencing the issue?
I'll get around to testing this later in the week.

@arouel
Copy link
Contributor Author

arouel commented May 24, 2022

Building it directly from this PR branch lead to the following error:

[ERROR] Failed to execute goal on project snowflake-jdbc: Could not resolve dependencies for project net.snowflake:snowflake-jdbc:jar:3.13.18: Could not transfer artifact net.minidev:json-smart:jar:2.3 from/to Central (https://nexus.int.snowflakecomputing.com/repository/maven-central/): authorization failed for https://nexus.int.snowflakecomputing.com/repository/maven-central/net/minidev/json-smart/2.3/json-smart-2.3.jar, status: 403 Forbidden -> [Help 1]

So there seem to be some repository restrictions on nexus.int.snowflakecomputing.com.

@lavandowska-datasite
Copy link

This could be Closed as #1017 has already resolved the issue.

@arouel arouel closed this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-755767: snowflake-jdbc driver fails with JDK >= 16
3 participants