SNOW-1651983 authenticated proxy on azure

snowflakedb · Sep 5, 2024 · 154478e · 154478e
1 parent 21c1e32
commit 154478e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/parent-pom.xml b/parent-pom.xml
@@ -24,7 +24,7 @@
     <avro.version>1.8.1</avro.version>
     <awaitility.version>4.2.0</awaitility.version>
     <awssdk.version>1.12.655</awssdk.version>
-    <azure.storage.version>5.0.0</azure.storage.version>
+    <azure.storage.version>8.6.6</azure.storage.version>
     <bouncycastle.version>1.74</bouncycastle.version>
     <bouncycastle.bcfips.version>1.0.2.4</bouncycastle.bcfips.version>
     <bouncycastle.bcpkixfips.version>1.0.5</bouncycastle.bcpkixfips.version>

diff --git a/src/main/java/net/snowflake/client/core/HttpUtil.java b/src/main/java/net/snowflake/client/core/HttpUtil.java
@@ -225,11 +225,13 @@ public static void setSessionlessProxyForAzure(
    */
   public static void setProxyForAzure(HttpClientSettingsKey key, OperationContext opContext) {
     if (key != null && key.usesProxy()) {
-      Proxy azProxy =
-          new Proxy(Proxy.Type.HTTP, new InetSocketAddress(key.getProxyHost(), key.getProxyPort()));
-      logger.debug(
-          "Setting Azure proxy. Host: {}, port: {}", key.getProxyHost(), key.getProxyPort());
+      Proxy azProxy = new Proxy(Proxy.Type.HTTP, new InetSocketAddress(key.getProxyHost(), key.getProxyPort()));
       opContext.setProxy(azProxy);
+      if (!Strings.isNullOrEmpty(key.getProxyUser()) && !Strings.isNullOrEmpty(key.getProxyPassword())) {
+        logger.debug("Setting Azure proxy with user. Host: {}, port: {}", key.getProxyHost(), key.getProxyPort());
+        opContext.setProxyUsername(key.getProxyUser());
+        opContext.setProxyPassword(key.getProxyPassword());
+      }
     } else {
       logger.debug("Omitting Azure proxy setup");
     }

diff --git a/src/test/java/net/snowflake/client/core/CoreUtilsMiscellaneousTest.java b/src/test/java/net/snowflake/client/core/CoreUtilsMiscellaneousTest.java
@@ -162,6 +162,8 @@ public void testSetProxyForAzure() {
             false);
     HttpUtil.setProxyForAzure(testKey, op);
     Proxy proxy = op.getProxy();
+    assertEquals("testuser", op.getProxyUsername());
+    assertEquals("pw", op.getProxyUsername());
     assertEquals(Proxy.Type.HTTP, proxy.type());
     assertEquals(new InetSocketAddress("snowflakecomputing.com", 443), proxy.address());
   }