Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1333163 support for default proxy #997

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-1333163 Add support for default proxy.

When specifying allowEmptyProxy=true and useProxy=true but without specifying the value of proxyHost, the proxy would be enabled but not configured allowing to use a default proxy provided by the operating system.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner July 29, 2024 12:54
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (sfc-gh-knozderko)[https://github.com/sfc-gh-knozderko]
@VincentCroquette
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.67%. Comparing base (982a1e4) to head (737d695).

Files Patch % Lines
Snowflake.Data/Core/Session/SFSessionProperty.cs 85.71% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #997      +/-   ##
==========================================
+ Coverage   85.55%   85.67%   +0.12%     
==========================================
  Files         106      106              
  Lines       10777    10809      +32     
  Branches     1032     1037       +5     
==========================================
+ Hits         9220     9261      +41     
+ Misses       1307     1299       -8     
+ Partials      250      249       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vc-74
Copy link

vc-74 commented Jul 29, 2024

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-knozderko sfc-gh-knozderko changed the title Snow 1333163 support for default proxy SNOW-1333163 support for default proxy Aug 1, 2024
Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants