Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-14887010 Structured types read for json result format #994

Merged
merged 47 commits into from
Sep 3, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Jul 16, 2024

Description

SNOW-14887010 Structured types read for json result format

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko force-pushed the SNOW-1488701_read_structured_types_json branch from 7ee117b to e20c7d3 Compare July 18, 2024 11:38
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the SNOW-1488701_read_structured_types_json branch from e20c7d3 to 938e4b1 Compare July 18, 2024 11:39
@sfc-gh-knozderko sfc-gh-knozderko marked this pull request as ready for review July 25, 2024 15:20
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 87.02011% with 71 lines in your changes missing coverage. Please review.

Project coverage is 85.64%. Comparing base (f178614) to head (71ec247).

Files with missing lines Patch % Lines
...ta/Core/Converter/JsonToStructuredTypeConverter.cs 86.89% 20 Missing and 18 partials ⚠️
Snowflake.Data/Core/Converter/TimeConverter.cs 70.58% 8 Missing and 7 partials ⚠️
.../Converter/Builder/ObjectBuilderByPropertyNames.cs 81.81% 4 Missing and 2 partials ⚠️
Snowflake.Data/Core/SFResultSetMetaData.cs 28.57% 5 Missing ⚠️
...re/Converter/Builder/ObjectBuilderByConstructor.cs 88.00% 2 Missing and 1 partial ⚠️
...ata/Core/Converter/Builder/ObjectBuilderFactory.cs 83.33% 1 Missing and 1 partial ⚠️
Snowflake.Data/Core/RestResponse.cs 88.88% 1 Missing ⚠️
Snowflake.Data/Core/SFDataConverter.cs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   85.66%   85.64%   -0.02%     
==========================================
  Files         106      117      +11     
  Lines       10801    11331     +530     
  Branches     1035     1130      +95     
==========================================
+ Hits         9253     9705     +452     
- Misses       1297     1345      +48     
- Partials      251      281      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko force-pushed the SNOW-1488701_read_structured_types_json branch from 14476a2 to e32269c Compare August 26, 2024 17:19
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-knozderko sfc-gh-knozderko merged commit a0bbeb0 into master Sep 3, 2024
53 of 54 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1488701_read_structured_types_json branch September 3, 2024 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants