-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-14887010 Structured types read for json result format #994
Merged
sfc-gh-knozderko
merged 47 commits into
master
from
SNOW-1488701_read_structured_types_json
Sep 3, 2024
Merged
SNOW-14887010 Structured types read for json result format #994
sfc-gh-knozderko
merged 47 commits into
master
from
SNOW-1488701_read_structured_types_json
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-knozderko
force-pushed
the
SNOW-1488701_read_structured_types_json
branch
from
July 18, 2024 11:38
7ee117b
to
e20c7d3
Compare
sfc-gh-knozderko
force-pushed
the
SNOW-1488701_read_structured_types_json
branch
from
July 18, 2024 11:39
e20c7d3
to
938e4b1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #994 +/- ##
==========================================
- Coverage 85.66% 85.64% -0.02%
==========================================
Files 106 117 +11
Lines 10801 11331 +530
Branches 1035 1130 +95
==========================================
+ Hits 9253 9705 +452
- Misses 1297 1345 +48
- Partials 251 281 +30 ☔ View full report in Codecov by Sentry. |
sfc-gh-mhofman
requested changes
Aug 1, 2024
Snowflake.Data.Tests/IntegrationTests/StructuredTypesWithEmbeddedUnstructuredIT.cs
Show resolved
Hide resolved
sfc-gh-mhofman
approved these changes
Aug 1, 2024
sfc-gh-knozderko
force-pushed
the
SNOW-1488701_read_structured_types_json
branch
from
August 26, 2024 17:19
14476a2
to
e32269c
Compare
sfc-gh-pmotacki
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-14887010 Structured types read for json result format
Checklist
dotnet test
)