Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-921048] Add Linter as mandatory github action #954

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-erojaslizano
Copy link
Contributor

@sfc-gh-erojaslizano sfc-gh-erojaslizano commented May 20, 2024

Description

Add the linter action as a mandatory step.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 12 lines in your changes missing coverage. Please review.

Project coverage is 85.54%. Comparing base (982a1e4) to head (7dc5bc3).

Files Patch % Lines
Snowflake.Data/Client/SnowflakeDbCommand.cs 86.79% 1 Missing and 6 partials ⚠️
Snowflake.Data/Core/Session/SFSessionProperty.cs 85.71% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
- Coverage   85.55%   85.54%   -0.01%     
==========================================
  Files         106      106              
  Lines       10777    10772       -5     
  Branches     1032     1032              
==========================================
- Hits         9220     9215       -5     
- Misses       1307     1308       +1     
+ Partials      250      249       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-erojaslizano sfc-gh-erojaslizano force-pushed the SNOW-921048-activate-linter branch 4 times, most recently from 91593a1 to a673805 Compare May 28, 2024 22:26
@sfc-gh-erojaslizano sfc-gh-erojaslizano force-pushed the SNOW-921048-activate-linter branch 2 times, most recently from 2840846 to e581e9b Compare July 9, 2024 20:14
@sfc-gh-erojaslizano sfc-gh-erojaslizano force-pushed the SNOW-921048-activate-linter branch 2 times, most recently from 4544c7c to cf8d096 Compare July 9, 2024 20:35
@sfc-gh-erojaslizano sfc-gh-erojaslizano changed the title test commit new linter action [SNOW-921048] Add Linter as mandatory github action Jul 9, 2024
@sfc-gh-erojaslizano sfc-gh-erojaslizano marked this pull request as ready for review July 9, 2024 21:33
@sfc-gh-erojaslizano sfc-gh-erojaslizano requested a review from a team as a code owner July 9, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant