-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better mock for sql executor to use in facade #1769
Draft
sfc-gh-pjafari
wants to merge
1
commit into
main
Choose a base branch
from
pj-new-mock-executor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+48
to
+49
def all_calls_made(self): | ||
return len(self._mock_results) == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idea, we can automate this:
Suggested change
def all_calls_made(self): | |
return len(self._mock_results) == 0 | |
def __enter__(): | |
return self | |
def __exit__(exc_type, exc_val, exc_tb): | |
if not (exc_type and exc_val and exc_tb): | |
num_remaining = len(self._mock_results) | |
assert num_remaining == 0, f"Some expected calls were not made, {num_remaining} remain" | |
return False # Don't suppress the exception |
use it as
validating_executor = MockQueriesExecutor(
expected_calls=[
("select current_role()", [mock_cursor([("old_role",)], [])]),
("use role mock_role", [None]),
("select current_warehouse()", [mock_cursor([("old_wh",)], [])]),
("use warehouse mock_wh", [None]),
("select current_database()", [mock_cursor([("old_db",)], [])]),
("use database mock_db", [None]),
(mock_script, [None]),
("use database old_db", [None]),
("use warehouse old_wh", [None]),
("use role old_role", [None]),
]
)
sql_facade = SnowflakeSQLFacade(validating_executor)
with validating_executor:
sql_facade.execute_user_script(
queries=mock_script,
script_name=mock_script_name,
role=role,
warehouse=wh,
database=database,
)
Comment on lines
+41
to
+44
if dedent(queries).strip() != dedent(query_expected).strip(): | ||
raise Exception( | ||
f"Test failed, expected query {query_expected} but received query {queries}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if dedent(queries).strip() != dedent(query_expected).strip(): | |
raise Exception( | |
f"Test failed, expected query {query_expected} but received query {queries}" | |
) | |
assert dedent(queries).strip() == dedent(query_expected).strip(), f"Expected query {query_expected} but received query {queries}" |
that way we get pytest assertion rewriting prettiness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
...