Ignore setting OCSP env if already set #1199
Conversation
Currently, if the user sets the OCSP cache server URL ``` SF_OCSP_RESPONSE_CACHE_SERVER_URL ``` it is never respected and always overwritten. This commit only sets the OCSP env vars if they are not already set by the user.
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Hi @concaf. Thanks for your suggestion. The thing is that apart from cache URL environment variable, there are also some others that have to be set apart from it (mainly Privatelink related). Also another issue with your solution is that it might introduce some unexpected behaviour when driver is as a multi-user instance. Could you explain your use-case? |
|
@sfc-gh-dheyman-1 my use case is that our codebase is deployed on an internal cluster that does not allow reaching out to port 80 ( |
| return nil, err | ||
|
|
||
| // only set OCSP envs if not already set | ||
| if _, set := os.LookupEnv(cacheServerURLEnv); !set { |
There was a problem hiding this comment.
could you move this check to ocsp.go to setupOCSPEnvVars function?
|
Hi again @concaf. Sorry for the late response. I discussed your case with my colleagues and we reached agreement that your solution won't interfere with current driver behaviour and if this actually helps you, let's add it :) |
Description
Currently, if the user sets the OCSP cache server URL
it is never respected and always overwritten.
This commit only sets the OCSP env vars if they are not already set by the user.
Checklist