Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve the following issue:
When multiple routes have the same FQDN and one or more of them is invalid (e.g. due to a non-existent target service), the controller will discard the whole set of routes.
For example, imagine we have a set of routes like this:
The openshift router will configure HAProxy so that
/a
and/c
is accessible but the controller will ignore the whole set of routes and no path will be accessible.The solution is to ignore the invalid routes and continue the reconciliation for other routes. A new problem arises here. If the target service for path
/b
is later created, we won't be informed. To solve this problem, the PR also adds a watch on KubernetesServices
.