Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore invalid routes #10

Merged
merged 6 commits into from
Aug 26, 2023
Merged

Ignore invalid routes #10

merged 6 commits into from
Aug 26, 2023

Conversation

therealak12
Copy link
Member

This PR tries to solve the following issue:

When multiple routes have the same FQDN and one or more of them is invalid (e.g. due to a non-existent target service), the controller will discard the whole set of routes.
For example, imagine we have a set of routes like this:

route FQDN path target service exists
route1 example.com /a yes
route2 example.com /b no
route2 example.com /c yes

The openshift router will configure HAProxy so that /a and /c is accessible but the controller will ignore the whole set of routes and no path will be accessible.

The solution is to ignore the invalid routes and continue the reconciliation for other routes. A new problem arises here. If the target service for path /b is later created, we won't be informed. To solve this problem, the PR also adds a watch on Kubernetes Services.

@therealak12 therealak12 marked this pull request as ready for review August 22, 2023 20:11
@therealak12 therealak12 self-assigned this Aug 22, 2023
@navidshariaty navidshariaty self-requested a review August 24, 2023 09:50
@therealak12 therealak12 merged commit d7327ea into main Aug 26, 2023
2 checks passed
@therealak12 therealak12 deleted the invalid-routes branch August 26, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants