fix: update prefix header tests to allow for empty headers #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
approved these changes
Oct 3, 2024
sugmanue
approved these changes
Oct 4, 2024
|
Just a side comment, please notice that Smithy does not use conventional commit messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
What do these changes do?
Update protocol tests to catch an issue where SDKs were not serializing empty headers
Why are they important?
Had an issue where calling S3 with metadata with an empty value caused SDKs to not serialize the value and not send the header. While serialize empty strings and lists to headers in restXml and restJson1 #2403 addresses the general case of headers present but with no values, it wouldn't cover this scenario since S3 metadata headers are not modeled as httpHeader but as httpPrefixHeader
Testing
Generated tests on smithy-go and ran the new tests on aws-sdk-go-v2
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.