Add unbound operation validator for protocol tests

smithy-lang · Oct 16, 2024 · 2f7a352 · 2f7a352
1 parent 5ec9e32
commit 2f7a352
Show file tree

Hide file tree

Showing 5 changed files with 47 additions and 0 deletions.
diff --git a/smithy-aws-protocol-tests/model/awsJson1_0/main.smithy b/smithy-aws-protocol-tests/model/awsJson1_0/main.smithy
@@ -41,5 +41,6 @@ service JsonRpc10 {
         OperationWithDefaults,
         OperationWithRequiredMembers,
         OperationWithNestedStructure
+        OperationWithRequiredMembersWithDefaults
     ]
 }
diff --git a/smithy-aws-protocol-tests/model/awsJson1_1/main.smithy b/smithy-aws-protocol-tests/model/awsJson1_1/main.smithy
@@ -26,6 +26,7 @@ service JsonProtocol {
         OperationWithOptionalInputOutput,
         PutAndGetInlineDocuments,
         JsonEnums,
+        JsonIntEnums
         NullOperation,
         SparseNullsOperation,
         GreetingWithErrors,

diff --git a/smithy-aws-protocol-tests/model/restJson1/main.smithy b/smithy-aws-protocol-tests/model/restJson1/main.smithy
@@ -65,6 +65,8 @@ service RestJson {
 
         // @httpResponseCode tests
         HttpResponseCode,
+        ResponseCodeRequired
+        ResponseCodeHttpFallback
 
         // @streaming tests
         StreamingTraits,
@@ -133,6 +135,7 @@ service RestJson {
         MalformedTimestampBodyDateTime,
         MalformedTimestampBodyHttpDate,
         MalformedContentTypeWithoutBody,
+        MalformedContentTypeWithoutBodyEmptyInput
         MalformedContentTypeWithBody,
         MalformedContentTypeWithPayload,
         MalformedContentTypeWithGenericString,

diff --git a/smithy-aws-protocol-tests/model/shared-types.smithy b/smithy-aws-protocol-tests/model/shared-types.smithy
@@ -18,6 +18,33 @@ metadata suppressions = [
     }
 ]
 
+metadata validators = [
+    {
+        name: "EmitEachSelector"
+        id: "UnboundTestOperation"
+        message: "This operation in the AWS protocol tests is not bound to a service."
+        namespaces: [
+            // Overall protocol test suites.
+            "aws.protocoltests.json10"
+            "aws.protocoltests.json"
+            "aws.protocoltests.query"
+            "aws.protocoltests.ec2"
+            "aws.protocoltests.restjson.validation"
+            "aws.protocoltests.restjson"
+            "aws.protocoltests.restxml"
+            "aws.protocoltests.restxml.xmlns"
+            // Service specific test suites.
+            "com.amazonaws.apigateway"
+            "com.amazonaws.glacier"
+            "com.amazonaws.machinelearning"
+            "com.amazonaws.s3"
+        ]
+        configuration: {
+            "selector": "operation :not(< service)"
+        }
+    }
+]
+
 namespace aws.protocoltests.shared
 
 list StringList {

diff --git a/smithy-protocol-tests/model/shared-types.smithy b/smithy-protocol-tests/model/shared-types.smithy
@@ -7,6 +7,21 @@
 
 $version: "2.0"
 
+metadata validators = [
+    {
+        name: "EmitEachSelector"
+        id: "UnboundTestOperation"
+        message: "This operation in the Smithy protocol tests is not bound to a service."
+        namespaces: [
+            // Overall protocol test suites.
+            "smithy.protocoltests.rpcv2Cbor"
+        ]
+        configuration: {
+            "selector": "operation :not(< service)"
+        }
+    }
+]
+
 namespace smithy.protocoltests.shared
 
 list StringList {