Ignoring unexpected server responses

slevomat · Jul 25, 2018 · 4c7485b · 4c7485b
1 parent 2dd14a4
commit 4c7485b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/src/Smtp/AsyncSmtpConnectionWriter.php b/src/Smtp/AsyncSmtpConnectionWriter.php
@@ -110,8 +110,9 @@ private function processDataResponse(string $data): void
 		$this->dataProcessingPromise = new \React\Promise\Deferred();
 
 		$this->logger->debug('RECEIVED DATA: ' . $data);
+
 		if (count($this->expectedResponses) === 0) {
-			throw new \AsyncConnection\Smtp\AsyncSmtpConnectionException(sprintf('Received unexpected data from server: %s.', $data));
+			return;
 		}
 
 		[$deferred, $expectedCodes, $message, $messageToReplace] = array_shift($this->expectedResponses);

diff --git a/tests/Smtp/AsyncSmtpConnectionWriterTest.php b/tests/Smtp/AsyncSmtpConnectionWriterTest.php
@@ -58,15 +58,6 @@ public function testInvalidStreamThrowsException(): void
 		new AsyncSmtpConnectionWriter($connectionMock, $this->logger);
 	}
 
-	public function testUnexpectedDataThrowException(): void
-	{
-		$this->expectException(\AsyncConnection\Smtp\AsyncSmtpConnectionException::class);
-		$this->expectExceptionMessage('Received unexpected data from server: 333 unexpectedServerResponse.');
-
-		new AsyncSmtpConnectionWriter($this->createConnectionMock(), $this->logger);
-		$this->runFailedTest('333 unexpectedServerResponse');
-	}
-
 	public function testUnexpectedConnectionEndFromServer(): void
 	{
 		$writer = new AsyncSmtpConnectionWriter($this->createConnectionMock(), $this->logger);