Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/skychat: basic p2p and group chat implementation #1494

Merged
merged 86 commits into from
Mar 14, 2024
Merged

Feature/skychat: basic p2p and group chat implementation #1494

merged 86 commits into from
Mar 14, 2024

Conversation

4rchim3d3s
Copy link
Contributor

@4rchim3d3s 4rchim3d3s commented Feb 19, 2023

Did you run make format && make check?

Yes

Fixes #

Changes:

  • Add basic support of p2p and group chats.
  • Add possibility to set user name and info

How to test this PR:

  1. build and install on two visors
  2. open both skychat UIs
  3. press on user icon to set user name and user info
  4. press on "Add local server and rooms" and type in at least an alias to generate a new server with a default room
  5. on skychat 'B' press on Add Remote Server and Rooms and type in all public keys you see on the user 'A's group info to connect to server

Known Bugs:
1. Sometimes the transports seem to hang up and only one can send to the other but not back
2. the sse connection of the browsers (to notify the browser that he has to do another http request to update the visor) doesnt work properly, so after sending and receiving messages one has to refresh the browser about 80% of the times.
3. Sending info with a picture does not work as it seems the picture needs more than one packet to be sent, so something needs to be implemented to send long data over skywire and put it back together

Preview:
Unbenannt

@0pcom 0pcom merged commit 4c200f6 into skycoin:feature/skychat Mar 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants