-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate Hiera values #20
base: master
Are you sure you want to change the base?
Conversation
1f11b18
to
974cbf4
Compare
* Add methods for retrieving profile names and confines * Compile data the way that compliance_markup does and validate the results * Handle a few error cases Fixes simp#14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's error out with duplicate parameters with different values. I don't think duplicate parameters setting the same value warrant a warning.
lib/scelint.rb
Outdated
|
||
if hiera.key?(setting['parameter']) | ||
if setting['value'].class.to_s != hiera[setting['parameter']].class.to_s | ||
warnings << [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this to add the value to the array only if the new setting is different than the old one. We should change also change it to an error rather than a warning of that condition is met. This would be the more appropriate behavior for this type of test in my opinion.
Historically,
|
Something isn't working as expected. The errors I'm getting point to rsyslog::tls_tcp_server being set to false from true, however, the checks that control that parameter are only mapped to enabled for el8 and only mapped to disabled for el7. This also doesn't appear to be finding some values I was expecting to show up in the list of failures such as useradd::useradd::inactive (same ces mapped to the values of 0, 30, 35, and 90) in rhel 8. |
|
Fixes #14