Reapply gdlpp changes on new fcpp upstream #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgermann
referenced
this pull request
Aug 8, 2019
|
We'll look at merging it after the upcoming release.
|
bgermann
referenced
this pull request
May 21, 2020
A variable (temp in cpp6.c:lookid) was being read before it was initialised. Fix this so Debug builds don't block the build agent with modal "Debug Error!" dialogs when running tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fcpp fork bkaradzic/fcpp is actively developed and holds a lot of improvements compared to the original bagder/fcpp that seems to be dead.
This PR imports the bkaradzic/fcpp version, adds most of the gdlpp changes as patches and applies them. The patches are kept to be able to import any upstream changes easily.
The change that is referenced in #5 is left out. Therefore this closes #5.
Upstream's makefile is not imported in favour of the existing Makefile.am and gdlpp.mak. Also, the fpp.{exp,fd} files are ignored.