Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault #5

Open
bgermann opened this issue Aug 8, 2018 · 6 comments
Open

Segfault #5

bgermann opened this issue Aug 8, 2018 · 6 comments

Comments

@bgermann
Copy link
Contributor

bgermann commented Aug 8, 2018

Commit 4ccd16d introduced a bug that crashes gdlpp. Find the details at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=715950

@sharoncorrell
Copy link
Contributor

sharoncorrell commented Sep 23, 2019

We are not including this in the next grcompiler release (v. 5.1).

@nrsiward
Copy link
Contributor

The linked Debian bug report is from 2013 and the attachment there that gives details of the bug is no longer available, so this will not be addressed.

@bgermann
Copy link
Contributor Author

The bug details are still available and valid for grcompiler 5.2.

@bgermann
Copy link
Contributor Author

To be more explicit: You run get() without checking for end of file first.

@nrsiward
Copy link
Contributor

This is a test case involving very atypical input which nonetheless should not cause a crash. We need to at least modify the code changed in the commit mentioned above which runs "get() without checking for end of file first".

@mhosken mhosken removed their assignment Aug 25, 2021
@mhosken
Copy link
Contributor

mhosken commented Aug 25, 2021

Passing this back. Just because I inserted \r handling doesn't mean I am in a position to fix this bug. It's not obvious to me from reading and will require someone with a test setup and debug to dig in and find where the EOF failure is coming in.

get() does EOF checking itself, so there should be no need for eof checking (which is tricky what with macros and #includes) at that point. I can believe the crash but not the proposed diagnostic solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants