New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposition to fix #163 #164

Open

klementc wants to merge 2 commits into signetlabdei:develop from klementc:bug-event-canceled

klementc commented Apr 22, 2024

This pull request fixes issue #163

Proposed Changes

Check nextTx is indeed a retransmission before assigning it to ensure we won't cancel another type of event
Schedule a new Send instead of doSend to recheck if the channel is available or if another delay has to be applied
Add debug log line at start of resetRetransmissionParameters

This does not break the tests, but tell me if it is a problem for another part of the LoRa code (I am still figuring out some of it)

klementc added 2 commits

April 22, 2024 11:39


          proposition to fix signetlabdei#163

2c10c44


          Fix clang format

046c9ad

non-det-alle self-requested a review

April 23, 2024 10:42

non-det-alle force-pushed the develop branch from d74117a to e56b6e3 Compare

July 28, 2024 10:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet