Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ecc scrub memory labels from linker scripts. #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove ecc scrub memory labels from linker scripts. #45

wants to merge 3 commits into from

Conversation

NandkumarJoshi
Copy link
Contributor

'scrub.s' no longer uses these generated labels.
Generator code is commented out, for a possible re-use should the need arise.

nick-knight
nick-knight reviewed Sep 24, 2020
View reviewed changes
templates/base.lds Outdated
@@ -104,7 +104,7 @@ SECTIONS
{% else %}
Copy link

@nick-knight nick-knight Sep 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This {% else %} clause was technical debt I added, and forgot to remove after you had weak-ened __metal_eccscrub_bit . Thanks!

bsousi5
bsousi5 reviewed Sep 25, 2020
View reviewed changes
Copy link
Collaborator

@bsousi5 bsousi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nick changes was also cherry picked into Kiwi.
Do we need to cherry pick this into Kiwi too?

templates/base.lds Outdated
@@ -87,11 +87,11 @@ SECTIONS
* certain core features */
PROVIDE(__metal_chicken_bit = {{ chicken_bit|default(0) }});

{% if eccscrub_en %}
{#{% if eccscrub_en %}#}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is no longer need and already verify that it I the case, better to simply delete this,

@NandkumarJoshi
Copy link
Contributor Author

Nick changes was also cherry picked into Kiwi.
Do we need to cherry pick this into Kiwi too?

yes.

@bsousi5
Copy link
Collaborator

bsousi5 commented Sep 25, 2020

Nick changes was also cherry picked into Kiwi.
Do we need to cherry pick this into Kiwi too?

yes.

update the above comment and I'll approve and merge this

bsousi5
bsousi5 approved these changes Sep 25, 2020
View reviewed changes
Copy link
Collaborator

@bsousi5 bsousi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsousi5
Copy link
Collaborator

bsousi5 commented Sep 25, 2020

@nategraff-sifive I will let you decide if you want this in 20.08 or not, and merge accordingly

@nategraff-sifive
Copy link
Contributor

@nategraff-sifive I will let you decide if you want this in 20.08 or not, and merge accordingly

I'm waiting until after the release.

@bsousi5
Copy link
Collaborator

bsousi5 commented Sep 25, 2020

@nategraff-sifive I will let you decide if you want this in 20.08 or not, and merge accordingly

I'm waiting until after the release.

Can you add this into Kiwi, so Kiwi can collapse into Koala next Monday

nategraff-sifive
nategraff-sifive approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@nategraff-sifive nategraff-sifive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nick-knight
nick-knight reviewed Sep 28, 2020
View reviewed changes
templates/base.lds Outdated Show resolved Hide resolved
Nick Knight and others added 2 commits September 28, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-knight nick-knight nick-knight left review comments

@bsousi5 bsousi5 bsousi5 approved these changes

@nategraff-sifive nategraff-sifive nategraff-sifive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NandkumarJoshi @bsousi5 @nategraff-sifive @nick-knight