Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop -e when masking secrets #446

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

frezbo
Copy link
Member

@frezbo frezbo commented Sep 5, 2024

If secrets contains a literal \n, echo -e would split it and would expose partial secrets. Fix by dropping -e.

If secrets contains a literal `\n`, `echo -e` would split it and would
expose partial secrets. Fix by dropping `-e`.

Signed-off-by: Noel Georgi <git@frezbo.dev>
@frezbo
Copy link
Member Author

frezbo commented Sep 5, 2024

/m

@talos-bot talos-bot merged commit 8be5fa7 into siderolabs:main Sep 5, 2024
14 checks passed
@frezbo frezbo deleted the fix/masking-secrets branch September 5, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants