Resolve search functionality bug with pagination #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @Slacky300! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
|
@Slacky300 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and help us grow even further! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the pagination issue where search results did not paginate correctly.
Related Issues
Fixes #1096
Changes Proposed
Flattened combined data structure for profile handling.
Reset current page to 1 on search to display the first page of search results.
Updated pagination logic to work with both full and filtered datasets.
In handleSearch function I reset the pag to 1 to show the first page of the search results
updated the logic to render the search list based on the search results
Checklist