Log bootstrap errors with BufferingLogger #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
APP_DEBUG=0(which is the default in theprodenvironment), if an exception occurs in the initial part of request processing (for example when the\Shopware\Storefront\Framework\Routing\Exception\SalesChannelMappingExceptionthrown in the\Shopware\Storefront\Framework\Routing\RequestTransformer::transform()method) nothing is logged. The developer will see a 500 error page without any clue about the problem.This is the kind of thing that wastes a lot of developers time.
This happens because in the very initial part of the request processing the
\Symfony\Component\ErrorHandler\ErrorHandleris not configured with any logger. It will then be configured by the Symfony kernel boot with Monolog but this happens after initial request processing exceptions are eventually thrown.See also this issue which is somehow related to this.