-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gnu_legacy feature #75
Conversation
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
0b68c98
to
20bf99c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
#[cfg(all( | ||
not(feature = "nu-ansi-term"), | ||
not(feature = "gnu_legacy"), | ||
not(feature = "ansi_term"), | ||
not(feature = "crossterm") | ||
))] | ||
compile_error!("one feature must be enabled: ansi_term, nu-ansi-term, crossterm, gnu_legacy"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sylvestre @alexkunde Turns out this is problematic when I want to run cargo publish
:
▶ cargo publish --dry-run
Updating crates.io index
Packaging lscolors v0.15.0 (/home/shark/software/lscolors)
Updating crates.io index
Verifying lscolors v0.15.0 (/home/shark/software/lscolors)
Compiling lscolors v0.15.0 (/home/shark/software/lscolors/target/package/lscolors-0.15.0)
error: one feature must be enabled: ansi_term, nu-ansi-term, crossterm, gnu_legacy
--> src/bin.rs:14:1
|
14 | compile_error!("one feature must be enabled: ansi_term, nu-ansi-term, crossterm, gnu_legacy");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
warning: unused import: `Style`
--> src/bin.rs:6:26
|
6 | use lscolors::{LsColors, Style};
| ^^^^^
|
= note: `#[warn(unused_imports)]` on by default
warning: `lscolors` (bin "lscolors") generated 1 warning
error: could not compile `lscolors` (bin "lscolors") due to previous error; 1 warning emitted
error: failed to verify package tarball
Any ideas on how to resolve this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you just need to make one of those features enabled by default. Right now even plain cargo build
fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, which one should be the default? nu-ansi-term?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submitted #76 which makes that the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. @sylvestre New release is out. Let me know if things are not working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. it improved the coreutils. I am debugging some issues to know if it is this change in lscolors or in the coreutils
thanks again
No description provided.