Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow *.ext=0 to override an earlier *.ext=... #46

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

tavianator
Copy link
Contributor

No description provided.

@sharkdp
Copy link
Owner

sharkdp commented Jun 12, 2022

Oh nice, thank you!

I hope we are eventually converging to something that is 100% compatible with ls. Was somehow imagining this to be a smaller topic when I initially started out with this projecft 🙃.

@sharkdp sharkdp merged commit 12ab04d into sharkdp:master Jun 12, 2022
@tavianator tavianator deleted the override-suffixes branch June 13, 2022 14:15
@tavianator
Copy link
Contributor Author

I hope we are eventually converging to something that is 100% compatible with ls. Was somehow imagining this to be a smaller topic when I initially started out with this projecft upside_down_face.

Haha yeah there is a surprising amount of complexity to LS_COLORS :)

Maybe we should open a tracking issue to document the remaining incompatibilities? There's at least

$ LS_COLORS="rs=RESET :lc=LEFT :rc=RIGHT :ex=EXECUTABLE " ls ./target/debug/lscolors 
LEFT RESET RIGHT LEFT EXECUTABLE RIGHT ./target/debug/lscolorsLEFT RESET RIGHT 
LEFT RIGHT 

@tavianator
Copy link
Contributor Author

Oh and escape sequences: https://github.com/tavianator/bfs/blob/33293e337ed4d9205b1185c44e1fe3fcb1a10af6/src/color.c#L197-L226

@sharkdp
Copy link
Owner

sharkdp commented Jun 15, 2022

Maybe we should open a tracking issue to document the remaining incompatibilities?

That would be great!

@tavianator
Copy link
Contributor Author

Done: #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants