feat!: enable ensure_consistent_versioning by default
#447
Conversation
| @@ -4060,7 +4060,7 @@ setprototypeof@1.2.0: | |||
| integrity sha512-E5LDX7Wrp85Kil5bhZv46j8jOeboKq5JMmYM3gVGdGH8xFpPWXUMsNrlODCrkoxMEeNi/XZIwuRvY4XNwYMJpw== | |||
|
|
|||
| "shakapacker@file:.yalc/shakapacker": | |||
| version "7.0.0-rc.0" | |||
| version "7.2.2" | |||
There was a problem hiding this comment.
this is annoying - pretty sure this'll need to be updated for CI whenever a new version is released, and is because Yarn doesn't update its lockfile when running in CI.
Will have a think on how we could handle this more gracefully
There was a problem hiding this comment.
Does this one matter past error being thrown on mismatch? If that's the only worry here then I'd probably just disable version check in https://github.com/shakacode/shakapacker/blob/next/spec/dummy/config/shakapacker.yml and move on 😅
There was a problem hiding this comment.
I considered that and I'm not fussed but arguably it is nicer to have it enabled since it's ensuring the out of box config works nicely.
Currently I'd say it should be fine to even land as-is because this'll only matter when a new version comes out which already requires bumping the version number elsewhere and takes a minute so should be fine to live with for now 🤷
There was a problem hiding this comment.
Aye, should be easy enough to get and hookup this update in any other bumps and release flows. We'll see it when it fails 😅
* Remove deprecated webpacker spelling (#429) * feat!: drop support for Ruby 2.6 (#415) * feat!: remove `https` option (#414) * feat!: remove `relative_url_root` option (#413) * feat!: drop support for Node v12 (#431) * feat!: remove `yarn_install` task (#412) * ci: cancel in-progress jobs when new changes are pushed (#432) * ci: merge ruby and node based jobs into single workflows (#434) * ci: merge node related checks into a single workflow * ci: merge ruby related checks into a single workflow * ci: rename jobs * ci: test against Ruby 3.1 and 3.2, and Node 20 (#433) * ci: test against Ruby 3.1 and 3.2 * ci: test against Node 20 * ci: only run Rubocop with latest Ruby (#438) * chore: update pull request template (#437) * ci: test against Rails 7.1 (#436) * feat!: remove `globalMutableWebpackConfig` (#439) * ci: don't run on pushes to `next` (#444) * feat!: remove `verify_file_existance` method (#446) * feat!: remove `check_yarn` task (#443) * ci: use latest bundler in generator jobs (#445) * feat!: enable `ensure_consistent_versioning` by default (#447) * Remove dependency on glob (#435) * Remove dependency on glob * Pass in shakapacker config consistently (#448) * Reference config from config rather than instance in compiler * Strip additional_paths from the asset paths generated in the file.js rule (#403) * Add config.includePaths and strip includePaths from file.js output paths * Refactor code to fix lint issue * Make sure to replace only once * Change variable name * Revert includePath change and make stripping additional_paths opt-in * refactor: use snake_case for method name (#450) * fix: only strip paths that start with source path (#451) * feat!: always use `package_json` for managing node packages (#430) * feat!: minor cleanup of js utilities (#454) * test: require `ostruct` explicitly (#460) * ci: only run ESLint on latest Node (#462) * docs: create upgrade guide for v8 (#458) * V8 upgrade guide * docs: write v8 upgrade doc * docs: format with Prettier * feat!: move tests and helpers into (#459) * test: move into `test` directory * test: update import paths * test: update jest config * refactor: move test helpers * test: move jest config into dedicated file * docs: add changelog entry * chore: remove unneeded eslint ignore * refactor: update js linting (#461) * refactor: setup and apply Prettier (#463) * refactor: use `eslint-plugin-jest` (#464)
Summary
Per the current messaging, we want this to be the default in the new major.
Pull Request checklist